Skip to content

Fix .env launch time loading#93

Open
zpalmtree wants to merge 1 commit into
exiled-apes:mainfrom
zpalmtree:patch-1
Open

Fix .env launch time loading#93
zpalmtree wants to merge 1 commit into
exiled-apes:mainfrom
zpalmtree:patch-1

Conversation

@zpalmtree
Copy link
Copy Markdown

@zpalmtree zpalmtree commented Oct 1, 2021

The initial go live date of the candy machine is loaded from the .env file. However, javascript's Date constructor expects to be given a value in milliseconds, not seconds, as is the convention for unix timestamps.
This bug may not have been observed, as the true go live date is loaded from the candy machine soon after page load.

Type of change

  • Bug fix

How Has This Been Tested?

  • Set REACT_APP_CANDY_START_DATE to a unix timestamp in the future, such as 1640998800 (2022)
  • Set candy machine backing it to have the same start date
  • Observe on load the 'Mint' button will be available for a few seconds before state is fetched from the server.
  • Presumably this can be extended for testing by disabling internet connection
  • After patch applied, Mint button should correctly show countdown right after page load

@thaking86
Copy link
Copy Markdown

thaking86 commented Oct 1, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants